self-development: distill recurring conventions from PR review feedback by kelos-bot[bot] · Pull Request #786 · kelos-dev/kelos

kelos-bot · 2026-03-24T18:08:18Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Distills eight recurring conventions from recent PR review feedback and propagates them across AGENTS.md, the shared and worker AgentConfigs, and the reviewer prompts. All changes are backed by specific PR review findings — no speculative rules.

1. Never use os.Getenv() for secrets as Go flag defaults

Evidence: PR Remove token-refresher sidecar, generate tokens in-process #971 — P1 security findings in cmd/kelos-webhook-server/main.go and cmd/ghproxy/main.go where os.Getenv("GITHUB_TOKEN") was used as flag.StringVar default, leaking the secret in --help output.
Applied to: AGENTS.md, agentconfig.yaml, kelos-workers.yaml, kelos-reviewer.yaml (new security checklist item).

2. Fail fast on invalid configuration

Evidence: PR Remove token-refresher sidecar, generate tokens in-process #971 — multiple P1/P2 findings where invalid GitHub App credentials, missing token resolvers, or failed token refreshes caused silent degradation (unauthenticated requests, skipped reporting) instead of erroring out.
Applied to: AGENTS.md, agentconfig.yaml, kelos-workers.yaml, kelos-reviewer.yaml (new correctness checklist item).

3. Keep API surfaces minimal

Evidence: PR feat(api): Add generic webhook source for arbitrary event-driven task spawning #902 — repeated maintainer feedback on the generic webhook API: "API is hard to fix, so I'd like to find the best way to design it" / "Can we defer these fields for now?" / "Let's make the minimal API for this PR."
Applied to: AGENTS.md, agentconfig.yaml, kelos-workers.yaml, kelos-api-reviewer.yaml (new compatibility checklist item).

4. API changes must preserve backward compatibility for existing manifests

Evidence: PR feat: add bodyPattern and excludeBodyPatterns regex filters for GitHub webhooks #1058 — three distinct findings on the same PR:
- Greptile P1: "Breaking schema change: BodyContains scalar → array" — existing in-cluster resources with bodyContains: "/kelos" (scalar) would fail Kubernetes structural-schema validation after the CRD update; the repo itself had at least 9 YAMLs in self-development/ and examples/ still using the old scalar form.
- Maintainer (gjkim42) asked twice: "Is this backward-compatible? Does setting +kubebuilder:validation:MinLength=1 allow empty BodyPattern?" and "I just want to make sure that the existing YAMLs that don't have bodyPattern (because it's a newly introduced field) can be applied. can we just remove minLength here?"
- Agreed resolution thread: add new fields and mark the old one +deprecated rather than remove it ("Why don't we add BodyPattern and ExcludeBodyPatterns and mark BodyContains deprecated here so that I can remove BodyContains later?").
This is distinct from "Keep API surfaces minimal" — minimal API is about scope of new additions; backward compatibility is about preserving existing manifests across CRD updates.
Applied to: AGENTS.md, agentconfig.yaml, kelos-workers.yaml, kelos-api-reviewer.yaml (two new bullets under "API compatibility and evolution": one on validation tightening / kind changes, one on sweeping stale YAMLs).

5. Docs must match implementation, not aspiration

Evidence:
- PR docs: Document GenericWebhook TaskSpawner source #1035 (kelos-bot[bot] P1): docs claimed HMAC signature validation per source, but the GenericSource branch in internal/webhook/handler.go never reads <SOURCE>_WEBHOOK_SECRET, inspects X-Hub-Signature-256, or calls validateHMACSignature — giving users a false sense of security.
- PR API: Add Workspace.spec.setupCommand for pre-agent setup #1056 (kelos-bot[bot] P2): doc note claimed PodOverrides.Env entries reusing reserved names are dropped so the built-in always wins, but the actual filter only drops collisions against names already populated on mainContainer.Env.
- PR feat(api): add excludePatterns to Slack source for negative routing #1082 (Greptile P1): the description and docs advertised that leading <@USER_ID> mentions are stripped before matching excludePatterns, but stripLeadingMentions was never implemented — anchored regexes silently failed against mention-prefixed messages.
Applied to: AGENTS.md, agentconfig.yaml, kelos-workers.yaml, kelos-reviewer.yaml (new "Documentation accuracy" checklist subsection).

6. TaskSpawner conventions

Evidence: PR self-development: add kelos-api-reviewer TaskSpawner #965 — three distinct corrections from maintainer (gjkim42): use webhook-based triggers over poll-based; handle empty {{.Branch}} for issue events; design issue_comment prompts for both issue and PR contexts. PR Add API contract validation example (example 12) #974 — P2: "Remove the manual PR branch checkout instruction; Kelos already handles PR branch checkout automatically."
Applied to: agentconfig.yaml, kelos-workers.yaml. README template-variable table corrected from "Usually PR head branch" to "PR head branch; empty for issue events".

7. Don't use Gomega's global Expect() inside Eventually polling blocks

Evidence: PR test(e2e): poll Task phase via WaitForTaskPhase to fix flake #1084 — flagged independently by Greptile (P2) and cubic-dev-ai (P2). The original GetTaskPhase helper called Expect(err).NotTo(HaveOccurred()), which propagates the panic and short-circuits Eventually's polling on the first transient API error instead of retrying. Other WaitFor* helpers in the framework already guard against this by returning a zero-value on error. The fix was to introduce WaitForTaskPhase that inlines the API call and returns "" on error.
Applied to: AGENTS.md, agentconfig.yaml, kelos-workers.yaml, kelos-reviewer.yaml (new bullet under the reviewer's Tests checklist).

8. /kind cleanup for self-development/-only PRs (new in latest commit)

Evidence: PR self-development: prevent kelos-bot from triggering self-development spawners #1100 (Greptile P2) — agent-generated PR modified only files under self-development/ but used /kind bug because the change was framed as a recursion-prevention bug fix. CLAUDE.md/AGENTS.md (line 34) already states the rule, but it was not echoed into the agent's agentsMD (where the other PR conventions are duplicated) nor in the reviewer's project-conventions checklist, so the worker missed it at PR-creation time and the kelos-reviewer pass did not flag it before merge.
Applied to: agentconfig.yaml, kelos-workers.yaml (echoed under Project Conventions); kelos-reviewer.yaml (new project-conventions checklist item with explicit P2 severity hint and the framing "classify by file location, not by problem nature").

Also fixes the kelos-reviewer TaskSpawner branch field to use the safe {{with index . "Branch"}}{{.}}{{else}}main{{end}} fallback form instead of bare {{.Branch}}. Flagged P2 by Greptile in this PR's prior review (#786): the spawner listens on issue_comment, so a /kelos review triggered on a plain issue would land on whatever default state Kelos falls back to rather than main.

Aligns the documented Branch fallback form with the canonical form (addresses Greptile P2 on this PR): the convention text in agentconfig.yaml:41 and kelos-workers.yaml:40 previously prescribed {{if .Branch}}{{.Branch}}{{else}}main{{end}}, but the spawner YAMLs all use {{with index . "Branch"}}{{.}}{{else}}main{{end}}. The new "Docs must match implementation" rule applies to itself — updated the documented example to match the deployed form.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

This PR has been rebased onto current main. All changes are documentation/configuration; no runtime code changes.

Does this PR introduce a user-facing change?

NONE

cubic-dev-ai

No issues found across 4 files

Add three new agent conventions from recent PR review feedback: 1. Per-TaskSpawner configuration should be CRD fields, not controller flags (PR #838 - gjkim42 review) 2. CRD API backward compatibility - never rename JSON field tags (PR #838 - P1 review finding) 3. Gate optional CRDs behind Helm values flags (PR #821 - PodMonitoring broke installs on clusters without monitoring.googleapis.com) Also includes previously proposed conventions from PR #786: - Consistent guidance across surfaces - Provider-agnostic API design - Idiomatic Helm values - Deploy-dev workflow sync - Controller-driven migration - Release note user action requirements Co-Authored-By: Claude Opus 4.6 <[email protected]>

gjkim42 · 2026-03-30T15:09:40Z

/kelos pick-up
rebase on origin/main

kelos-bot · 2026-03-30T15:42:21Z

🤖 Kelos Task Status

Task kelos-pr-responder-786 has succeeded. ✅

kelos-bot · 2026-03-30T15:57:12Z

🤖 Kelos Agent @gjkim42

/kelos needs-input

Rebased on origin/main (was already up to date). Added kind/cleanup label to fix check-pr-labels CI check. Updated PR body formatting.

The only failing CI check is comment-label — this is a repo-level permissions issue (kelos-bot[bot] lacks write access), not related to this PR. All core checks (build, test, verify, e2e, integration) passed on the current commit.

Ready for re-review.

…eedback Adds conventions learned from recent PR reviews: 1. Fail fast on invalid configuration (PR #971): three P1 and four P2 issues flagged silent degradation when credentials or config were invalid, falling back to unauthenticated requests instead of erroring. 2. No manual PR branch checkout in TaskSpawner prompts (PR #974): Kelos already checks out the PR branch automatically; manual checkout instructions are redundant and confusing. Also carries forward the previously proposed changes from PR #786: - os.Getenv() secret-in-flag-defaults convention (PR #971) - TaskSpawner creation conventions (PR #965) - Branch template variable documentation fix (PR #965) Co-Authored-By: Claude Opus 4.6 <[email protected]>

greptile-apps · 2026-04-30T18:08:34Z

Greptile Summary

This documentation/configuration-only PR distills seven recurring conventions from recent PR review feedback and propagates them consistently across AGENTS.md, the shared and worker AgentConfigs, and the reviewer prompt templates. It also fixes the previously flagged bare {{.Branch}} in kelos-reviewer.yaml and corrects the README template-variable table.

All changes are config/docs; no runtime code is touched. One P2 finding: kelos-squash-commits.yaml (outside this PR's diff) also listens on issue_comment without commentOn: PullRequest filtering and still uses bare {{.Branch}} — the same pattern this PR fixes in kelos-reviewer.yaml.

Confidence Score: 5/5

Safe to merge — all changes are documentation and configuration with no runtime impact.

No P0 or P1 findings. The single P2 is in a file outside this diff (kelos-squash-commits.yaml), and the changes in-diff are well-evidenced and internally consistent.

self-development/kelos-squash-commits.yaml (outside diff) still uses bare {{.Branch}} without a PR-only filter and should be updated in a follow-up.

Important Files Changed

Filename	Overview
AGENTS.md	Adds six new engineering conventions distilled from PR review findings; all are well-scoped and consistent with the PR description.
self-development/README.md	Corrects the {{.Branch}} description from 'Usually PR head branch or push branch' to the more accurate 'PR head branch; empty for issue events'.
self-development/agentconfig.yaml	Propagates all seven conventions to the shared AgentConfig; the documented branch-fallback example correctly uses the {{with index . "Branch"}} form matching deployed spawners.
self-development/kelos-reviewer.yaml	Fixes the previously-flagged bare {{.Branch}} to the safe {{with index . "Branch"}}…{{else}}main{{end}} form; adds correctness, tests, conventions, security, and documentation-accuracy checklist items.
self-development/kelos-api-reviewer.yaml	Adds three new API-compatibility checklist items covering minimal surface, backward compatibility, and stale-manifest sweeps; all well-aligned with the PR evidence.
self-development/kelos-workers.yaml	Adds the same seven conventions to the worker AgentConfig; the kelos-workers spawner itself is unaffected since it uses a fixed branch name and issue-only comment filters.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[issue_comment event fires] --> B{commentOn filter on spawner?}
    B -->|commentOn: PullRequest| C[Branch always populated]
    B -->|No commentOn filter| D{Triggered from PR or Issue?}
    D -->|PR context| E[Branch = PR head branch]
    D -->|Plain issue context| F[Branch = empty string]
    F --> G{branch field template used}
    G -->|bare .Branch| H["BROKEN: empty branch, Kelos uses unknown fallback - kelos-squash-commits.yaml not fixed in this PR"]
    G -->|with index . Branch else main| I["SAFE: falls back to main - kelos-reviewer.yaml fixed in this PR"]
    E --> I
    C --> I

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
self-development/kelos-squash-commits.yaml:54
**Bare `{{.Branch}}` not updated — convention applies here too**

This spawner listens on `issue_comment` events without a `commentOn: PullRequest` filter (unlike `kelos-pr-responder.yaml`), so `/kelos squash-commits` typed on a plain issue would trigger it with an empty `{{.Branch}}`. The PR documents the fix as a convention in `agentconfig.yaml` and `kelos-workers.yaml`, and applies it to `kelos-reviewer.yaml`, but misses this file.

```suggestion
    branch: '{{with index . "Branch"}}{{.}}{{else}}main{{end}}'
```

_{Reviews (5): Last reviewed commit: "self-development: surface /kind cleanup ..." | Re-trigger Greptile}

Adds five conventions distilled from recent PR reviews and applies them across AGENTS.md, the shared and worker AgentConfigs, and the reviewer prompts. 1. Never use os.Getenv() for secrets as Go flag defaults (PR #971) — flag prints defaults in --help output, leaking secret values. 2. Fail fast on invalid configuration (PR #971) — do not silently fall back to unauthenticated/degraded behavior when credentials or config are missing. 3. Keep API surfaces minimal (PR #902) — only fields immediately needed, no speculative additions; API is hard to change once shipped. 4. Docs must match implementation, not aspiration (PRs #1035, #1056) — describe only what the code actually does; verify enforcement before documenting a contract. 5. TaskSpawner conventions (PRs #965, #974): - Prefer webhook-based triggers over poll-based. - {{.Branch}} is empty for issue-only events; use the {{if .Branch}}{{.Branch}}{{else}}main{{end}} fallback form. - issue_comment fires for both issues and PRs; design prompts to detect and handle both contexts. - Do not include manual PR branch checkout instructions — Kelos checks out the PR branch automatically. Also fixes the kelos-reviewer TaskSpawner branch field to use the safe fallback form (was using bare {{.Branch}}, which is empty for issue events; flagged P2 in PR #786 review). Co-Authored-By: Claude Opus 4.7 <[email protected]>

cubic-dev-ai · 2026-05-02T18:05:17Z

You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment @cubic-dev-ai review.

Adds five conventions distilled from recent PR reviews and applies them across AGENTS.md, the shared and worker AgentConfigs, and the reviewer prompts. 1. Never use os.Getenv() for secrets as Go flag defaults (PR #971) — flag prints defaults in --help output, leaking secret values. 2. Fail fast on invalid configuration (PR #971) — do not silently fall back to unauthenticated/degraded behavior when credentials or config are missing. 3. Keep API surfaces minimal (PR #902) — only fields immediately needed, no speculative additions; API is hard to change once shipped. 4. Docs must match implementation, not aspiration (PRs #1035, #1056) — describe only what the code actually does; verify enforcement before documenting a contract. 5. TaskSpawner conventions (PRs #965, #974): - Prefer webhook-based triggers over poll-based. - {{.Branch}} is empty for issue-only events; use the {{if .Branch}}{{.Branch}}{{else}}main{{end}} fallback form. - issue_comment fires for both issues and PRs; design prompts to detect and handle both contexts. - Do not include manual PR branch checkout instructions — Kelos checks out the PR branch automatically. Also fixes the kelos-reviewer TaskSpawner branch field to use the safe fallback form (was using bare {{.Branch}}, which is empty for issue events; flagged P2 in PR #786 review). Co-Authored-By: Claude Opus 4.7 <[email protected]>

PR #1058 surfaced a recurring API-change pattern not covered by the existing "Keep API surfaces minimal" rule: - A scalar -> array kind change on an existing CRD field (BodyContains) was flagged P1 because existing in-cluster resources would fail structural-schema validation; the repo itself had ~9 stale YAMLs in self-development/ and examples/ still using the old scalar form. - The maintainer asked twice about backward compatibility on a newly added BodyPattern field, and required removing +kubebuilder:validation:MinLength=1 because it would reject existing YAMLs that don't yet have the field. - The agreed migration path was to add new fields and mark the old one +deprecated rather than remove it. Adds the convention to AGENTS.md (and CLAUDE.md via symlink), to the shared agentconfig.yaml and kelos-workers.yaml, and to the kelos-api-reviewer prompt as an explicit checklist item under "API compatibility and evolution". Co-Authored-By: Claude Opus 4.7 <[email protected]>

…ing convention Greptile flagged a P2 inconsistency on PR #786 itself: the convention text in agentconfig.yaml and kelos-workers.yaml prescribed {{if .Branch}}{{.Branch}}{{else}}main{{end}}, but the canonical form used in the spawner YAMLs (kelos-reviewer.yaml, kelos-api-reviewer.yaml) is {{with index . "Branch"}}{{.}}{{else}}main{{end}}. The new "Docs must match implementation" rule applies to itself — fix the documented example to match the deployed form. PR #1084 fixed an e2e flake caused by GetTaskPhase calling the global Expect(err).NotTo(HaveOccurred()) inside an Eventually polling loop; Gomega does not retry on Expect failures, so a transient API error short-circuits the poller. Both Greptile and cubic-dev-ai flagged the same anti-pattern. Capture the lesson in AGENTS.md, the shared and worker AgentConfigs, and add a reviewer checklist item so future WaitFor* helpers either return a zero-value on error or use the Eventually(func(g Gomega) { ... }) form.

kelos-bot · 2026-05-03T18:06:33Z

🤖 Kelos Agent @gjkim42

Pushed two new updates:

Aligned the documented Branch fallback form with the canonical form used in the spawner YAMLs ({{with index . "Branch"}}{{.}}{{else}}main{{end}}). Addresses Greptile's P2 finding on this PR — the new "Docs must match implementation" rule applies to itself.
Added a new convention distilled from PR test(e2e): poll Task phase via WaitForTaskPhase to fix flake #1084's reviews: don't use Gomega's global Expect() inside Eventually polling blocks (Gomega does not retry on Expect failures). Both Greptile and cubic-dev-ai flagged the same anti-pattern. Captured in AGENTS.md, the shared and worker AgentConfigs, and the reviewer's Tests checklist.

Branch was rebased on origin/main before pushing.

…y PRs PR #1100 was an agent-generated PR that modified only self-development/ files but used /kind bug. Greptile flagged it P2 against the existing CLAUDE.md/AGENTS.md rule: PRs that only modify files under self-development/ are internal agent improvements — use /kind cleanup and write NONE in the release-note block. The rule lives in the project's AGENTS.md but was not echoed into the agent's own agentsMD (where most other PR conventions are duplicated) nor surfaced in the reviewer's project-conventions checklist. So the worker missed it at PR-creation time, and the kelos-reviewer pass did not catch it before merge. Echo the rule into the shared and worker AgentConfigs, and add an explicit reviewer checklist item with a P2 severity hint so a /review pass on a self-development/-only PR will flag a wrong /kind label. The framing emphasizes "classify by file location, not by problem nature" — the failure mode in PR #1100 was the agent picking the label from the change's semantic intent (recursion-prevention bug fix) rather than from the directory scope.

kelos-bot · 2026-05-04T18:05:13Z

🤖 Kelos Agent @gjkim42

Pushed one new commit (cea8c90):

/kind cleanup rule for self-development/-only PRs — distilled from PR #1100's Greptile P2. The convention exists in AGENTS.md (line 34) but was missed by the worker at PR-creation time and not surfaced in the reviewer's project-conventions checklist. Echoed it into the shared and worker AgentConfigs and added a P2 reviewer checklist item with the framing "classify by file location, not by problem nature".

Branch was rebased on origin/main before pushing. PR description updated to include the new convention.

kelos-bot Bot added generated-by-kelos ok-to-test labels Mar 24, 2026

github-actions Bot added needs-triage needs-kind Indicates an issue or PR lacks a kind/* label needs-priority needs-actor release-note-none labels Mar 24, 2026

cubic-dev-ai Bot reviewed Mar 24, 2026

View reviewed changes

kelos-bot Bot mentioned this pull request Mar 26, 2026

Workflow Completeness: PR-creating prompts omit /kind labels, causing needs-kind on agent PRs #802

Open

kelos-bot Bot changed the title ~~Add pre-push verification and cross-surface update conventions~~ Add deploy-dev sync, controller migration, and release note conventions Mar 28, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from bcdeef3 to 7ade17e Compare March 29, 2026 18:06

kelos-bot Bot changed the title ~~Add deploy-dev sync, controller migration, and release note conventions~~ Add CRD design, API compatibility, and Helm gating conventions Mar 29, 2026

kelos-bot Bot added kind/cleanup and removed needs-kind Indicates an issue or PR lacks a kind/* label labels Mar 30, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 7ade17e to 782ce1c Compare March 30, 2026 18:13

kelos-bot Bot changed the title ~~Add CRD design, API compatibility, and Helm gating conventions~~ Add Helm CRD escaping, Docker pinning, and Go safety conventions Mar 30, 2026

kelos-bot Bot changed the title ~~Add Helm CRD escaping, Docker pinning, and Go safety conventions~~ Add test synchronization, RBAC, and Go safety conventions Apr 1, 2026

kelos-bot Bot changed the title ~~Add test synchronization, RBAC, and Go safety conventions~~ Sync worker agent conventions and broaden K8s comparison rule Apr 2, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 0871329 to 6379545 Compare April 3, 2026 18:15

kelos-bot Bot changed the title ~~Sync worker agent conventions and broaden K8s comparison rule~~ Add new agent conventions from PR review feedback and sync worker agent Apr 3, 2026

kelos-bot Bot changed the title ~~Add new agent conventions from PR review feedback and sync worker agent~~ Propagate conventions to all agents and add new rules from PR reviews Apr 4, 2026

kelos-bot Bot mentioned this pull request Apr 7, 2026

Prompt Tuning: kelos-config-update missing branch setup step — stale branch accumulates changes without rebasing #924

Open

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 6f6241c to 41ed5c4 Compare April 7, 2026 18:06

kelos-bot Bot changed the title ~~Propagate conventions to all agents and add new rules from PR reviews~~ Add consistent parallel paths convention and fix workers prompt bug Apr 7, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 41ed5c4 to 5f6baa8 Compare April 8, 2026 18:08

kelos-bot Bot changed the title ~~Add consistent parallel paths convention and fix workers prompt bug~~ Add testing conventions, parallel paths, and fix agent prompt bugs Apr 8, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 5f6baa8 to 675ac75 Compare April 9, 2026 18:12

kelos-bot Bot changed the title ~~Add testing conventions, parallel paths, and fix agent prompt bugs~~ Add API surface convention, sync agent configs, and fix prompt bugs Apr 9, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from eb7fce3 to f472430 Compare April 12, 2026 18:10

kelos-bot Bot changed the title ~~Add API surface convention, sync agent configs, and fix prompt bugs~~ Add secret-in-flag-defaults convention and clarify Branch template variable Apr 12, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 1d88c65 to 0d360ce Compare April 14, 2026 18:07

kelos-bot Bot changed the title ~~Add secret-in-flag-defaults convention and clarify Branch template variable~~ Add fail-fast convention, no-manual-checkout rule, and secret-in-flag-defaults Apr 14, 2026

kelos-bot Bot changed the title ~~Add fail-fast convention, no-manual-checkout rule, and secret-in-flag-defaults~~ Add fail-fast, no-manual-checkout, secret-flag-default, and docs-accuracy conventions Apr 30, 2026

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 7aff731 to 6a74ec3 Compare May 1, 2026 18:09

kelos-bot Bot changed the title ~~Add fail-fast, no-manual-checkout, secret-flag-default, and docs-accuracy conventions~~ self-development: distill recurring conventions from PR review feedback May 1, 2026

gjkim42 and others added 3 commits May 3, 2026 18:03

kelos-bot Bot force-pushed the kelos-config-update-latest branch from 2d628c4 to bdbd438 Compare May 3, 2026 18:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

self-development: distill recurring conventions from PR review feedback#786

self-development: distill recurring conventions from PR review feedback#786
kelos-bot[bot] wants to merge 4 commits intomainfrom
kelos-config-update-latest

kelos-bot Bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

gjkim42 commented Mar 30, 2026

Uh oh!

kelos-bot Bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

kelos-bot Bot commented Mar 30, 2026

Uh oh!

greptile-apps Bot commented Apr 30, 2026 •

edited

Loading

Important Files Changed

Uh oh!

cubic-dev-ai Bot commented May 2, 2026

Uh oh!

kelos-bot Bot commented May 3, 2026

Uh oh!

kelos-bot Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kelos-bot Bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gjkim42 commented Mar 30, 2026

Uh oh!

kelos-bot Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kelos-bot Bot commented Mar 30, 2026

Uh oh!

greptile-apps Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

cubic-dev-ai Bot commented May 2, 2026

Uh oh!

kelos-bot Bot commented May 3, 2026

Uh oh!

kelos-bot Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kelos-bot Bot commented Mar 24, 2026 •

edited

Loading

kelos-bot Bot commented Mar 30, 2026 •

edited

Loading

greptile-apps Bot commented Apr 30, 2026 •

edited

Loading